Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for desugaring #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove need for desugaring #117

wants to merge 3 commits into from

Conversation

mattmook
Copy link
Member

@mattmook mattmook commented Jul 4, 2024

Fixes #115

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.96%. Comparing base (e9a9896) to head (bbf9f82).
Report is 2 commits behind head on main.

Files Patch % Lines
...ransparency/internal/utils/asn1/GeneralizedTime.kt 0.00% 10 Missing ⚠️
...atetransparency/internal/loglist/model/v3/State.kt 50.00% 3 Missing ⚠️
...ency/internal/loglist/model/v3/TemporalInterval.kt 0.00% 2 Missing ⚠️
.../certificatetransparency/internal/utils/Rfc3339.kt 93.54% 0 Missing and 2 partials ⚠️
...ternal/loglist/deserializer/Rfc3339Deserializer.kt 66.66% 1 Missing ⚠️
...ency/internal/loglist/model/v3/PreviousOperator.kt 0.00% 1 Missing ⚠️
...ertificatetransparency/internal/utils/asn1/ASN1.kt 50.00% 0 Missing and 1 partial ⚠️
...ificatetransparency/internal/utils/asn1/UTCTime.kt 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
- Coverage     74.33%   73.96%   -0.37%     
+ Complexity      508      507       -1     
============================================
  Files           117      118       +1     
  Lines          2092     2105      +13     
  Branches        325      326       +1     
============================================
+ Hits           1555     1557       +2     
- Misses          399      409      +10     
- Partials        138      139       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desugaring and AGP version related crash
1 participant
@mattmook