Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Base64 implementation with version from Kotlin 1.8.20 #59

Open
mattmook opened this issue Feb 24, 2023 · 4 comments
Open

Replace Base64 implementation with version from Kotlin 1.8.20 #59

mattmook opened this issue Feb 24, 2023 · 4 comments

Comments

@mattmook
Copy link
Member

See https://kotlinlang.org/docs/whatsnew-eap.html#experimental-support-for-base64-encoding-in-standard-library

This can only be done once 1.8.20 is released and out of beta.
@ccodega
Copy link
Contributor

ccodega commented Apr 24, 2023

kotlin 1.8.20 is out of beta! :)

@mattmook
Copy link
Member Author

it is... I have a branch open with updated code in - there are some subtle differences in Kotlin's implementation so I'm making sure I'm happy first

@mattmook
Copy link
Member Author

mattmook commented Apr 25, 2023 •
edited
Loading

As the feature is marked experimental I won't be pushing the change into the lib immediately; although I will push upgrading to kotlin 1.8.20

@mattmook
Copy link
Member Author

mattmook commented Oct 5, 2023

Still experimental in Kotlin 1.9.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmook @ccodega