-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Must LoggerSeverity (namespace) needed to be exposed? #1114
Comments
Are you saying that asciidoctor.js/packages/core/types/index.d.ts Lines 394 to 396 in 3384a6b
|
Nope...it should be useable, but I see no place where it is actually used. |
OK, I didn't know 😄 I guess we could add a test in |
It's actually usage is only internal, since the namespace is not ported to the outside...at least not in typescript. However the code is speaking about it. The question is, if it should be exposed (so adding to the Asciidoctor class LoggerSeverity) or let it internal (so the type definition is dead code and should be delete, since it is basically just there). |
Ah...so my first answer was wrong... |
This question refers only to the types, not to the actual code, since the usage there is clear by the context.
The text was updated successfully, but these errors were encountered: