Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wctdm24xxp: MAX macro redefined #61

Open
InterLinked1 opened this issue Sep 22, 2024 · 0 comments · May be fixed by #62
Open

wctdm24xxp: MAX macro redefined #61

InterLinked1 opened this issue Sep 22, 2024 · 0 comments · May be fixed by #62

Comments

@InterLinked1
Copy link
Contributor

MAX can already be defined and causes a compilation error due to being redefined:

  CC [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.o
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c: In function 'wait_access':
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:1519: error: "MAX" redefined [-Werror]
 1519 |         #define MAX 10 /* attempts */
      | 
In file included from ./include/linux/kernel.h:28,
                 from /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:41:
./include/linux/minmax.h:330: note: this is the location of the previous definition
  330 | #define MAX(a,b) __cmp(max,a,b)
cc1: all warnings being treated as errors
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Sep 22, 2024
@InterLinked1
wctdm24xxp: Rename MAX definition to avoid macro naming conflict.
16be87e 
MAX can already be defined by the kernel headers and cause
compilation failure due to the redefinition, so use
MAX_ATTEMPTS to a more descriptive and non-conflicting name.

Resolves: asterisk#61
@InterLinked1 InterLinked1 linked a pull request Sep 22, 2024 that will close this issue
Open
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Sep 23, 2024
@InterLinked1
drivers: Rename MAX definition to avoid macro naming conflict.
2973a4b 
MAX can already be defined by the kernel headers and cause
compilation failure due to the redefinition, so use
MAX_ATTEMPTS to a more descriptive and non-conflicting name.

Resolves: asterisk#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wctdm24xxp: Rename MAX definition to avoid macro naming conflict. InterLinked1/dahdi-linux
1 participant
@InterLinked1