Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing code examples #183

Open
yd-yin opened this issue Aug 16, 2020 · 2 comments
Open

Testing code examples #183

yd-yin opened this issue Aug 16, 2020 · 2 comments

Comments

@yd-yin
Copy link

yd-yin commented Aug 16, 2020

Like this nice work of rl codebase. It's nice and pretty!

I wonder if there is any evaluation examples? I mean we have build and train, but do we have build and test?

@yd-yin yd-yin changed the title Testing examples Testing code examples Aug 19, 2020
@astooke
Copy link
Owner

astooke commented Sep 5, 2020

Hi! Good question. That isn't built in explicitly, but what I usually to do test is make copy of the script that has build_and_train in it, call it script_test.py, and inside that one I'll manually change whatever configurations I'm testing, and usually also set the config["runner"]["n_steps"] and config["runner"]["log_interval_steps"] to be small values, so that the diagnostics come back fast. Just remove the variant loading, and use something simple for the affinity code like: 0slt_1gpu_4cpu (if you have 4 cpus) or 0slot_0gpu_4cpu_4cpr if you have 4 cpus but no gpus.

Does that make sense?

@yd-yin
Copy link
Author

yd-yin commented Sep 10, 2020

Hi! Thanks for the response. I got you, but still, building an explicit build and test may lower the difficulty for new comers (like me).

Actually, I finally refered to the code from https://github.com/petrikvladimir/rlpyt_examples, where there are build and test function and simple examples on simple environments like cartpole.

Do you think the usage of rlpyt in this repo is okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants