Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support encoded | for use programmatically #80

Open
jeaye opened this issue Dec 31, 2021 · 2 comments
Open

Feature request: support encoded | for use programmatically #80

jeaye opened this issue Dec 31, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jeaye
Copy link

jeaye commented Dec 31, 2021

Hi there. I was trying to make a request to "https://css.gg/css?=link|bulb" from the JVM and it's a real pain, since | is not a valid character for java.net URL parsers, which applies to Java, Clojure, etc, and all libraries in their ecosystems.

So, the request is for css.gg to also support "https://css.gg/css?=link%7Cbulb", which has | encoded as %7C so that it can be used programmatically. If the css.gg API were to URL decode the params, this shouldn't make any difference to existing behavior. However, we can see the impact as I illustrate with these two curl commands:

curl "https://css.gg/css?=link|bulb"
.gg-bulb{box-sizing:border-box;position:relative;display:block;transform:scale(var(--ggs,1));width:16px;height:16px;border:2px solid;border-bottom-color:transparent;border-radius:100px}.gg-bulb::after,.gg-bulb::before{content:"";display:block;box-sizing:border-box;position:absolute}.gg-bulb::before{border-top:0;border-bottom-left-radius:18px;border-bottom-right-radius:18px;top:10px;border-bottom:2px solid transparent;box-shadow:0 5px 0 -2px,inset 2px 0 0 0,inset -2px 0 0 0,inset 0 -4px 0 -2px;width:8px;height:8px;left:2px}.gg-bulb::after{width:12px;height:2px;border-left:3px solid;border-right:3px solid;border-radius:2px;bottom:0;left:0}
.gg-link{box-sizing:border-box;position:relative;display:block;transform:rotate(-45deg) scale(var(--ggs,1));width:8px;height:2px;background:currentColor;border-radius:4px}.gg-link::after,.gg-link::before{content:"";display:block;box-sizing:border-box;position:absolute;border-radius:3px;width:8px;height:10px;border:2px solid;top:-4px}.gg-link::before{border-right:0;border-top-left-radius:40px;border-bottom-left-radius:40px;left:-6px}.gg-link::after{border-left:0;border-top-right-radius:40px;border-bottom-right-radius:40px;right:-6px}curl "https://css.gg/css?=link%7Cbulb"
.gg-link{box-sizing:border-box;position:relative;display:block;transform:rotate(-45deg) scale(var(--ggs,1));width:8px;height:2px;background:currentColor;border-radius:4px}.gg-link::after,.gg-link::before{content:"";display:block;box-sizing:border-box;position:absolute;border-radius:3px;width:8px;height:10px;border:2px solid;top:-4px}.gg-link::before{border-right:0;border-top-left-radius:40px;border-bottom-left-radius:40px;left:-6px}.gg-link::after{border-left:0;border-top-right-radius:40px;border-bottom-right-radius:40px;right:-6px}

The first one works, since curl is fine not encoding the param, but, with the encoded param, css.gg only returns CSS for the first icon.

Thanks for the consideration!

@jeaye
Copy link
Author

jeaye commented Jan 11, 2022

Hi! Happy new year. Any chance you considered this?

@astrit astrit self-assigned this Jun 23, 2023
@astrit astrit added the bug Something isn't working label Jun 23, 2023
@astrit
Copy link
Owner

astrit commented Jun 23, 2023

@jeaye sorry for late reply, this has been noted and hopefully will fix soon ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants