You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like the issue here is that enable_cloud_dataset and disable_cloud_datset are defined on the base class of TesscutClass, which is MastQueryWithLogin.
Some options:
Override the functions in TesscutClass, issue a deprecation warning, and add a :private directive to hide them from the docs.
Override the functions in TesscutClass and raise an exception.
Move the functions into the child classes excluding TesscutClass.
I'm leaning towards Option 1, but I wanted to check if there is a standard already in place for this type of thing.
If these are used in child classes, you could also raise NotImplementedError in the base class with a message that it should be defined in child classes. Ultimately, it is up to you, as I am unfamiliar with MAST API internals. Thanks!
As requested by @orionlee in #1521 (comment)
Public documentation should probably be updated, as
TessCut
class still have the documentedenable_cloud_dataset()
anddisable_cloud_dataset()
methods that are essentially no-ops.The text was updated successfully, but these errors were encountered: