Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Review changes of repository klaaspeter/achievo #10

Open
PhrozenByte opened this issue Nov 19, 2013 · 2 comments
Open

Review changes of repository klaaspeter/achievo #10

PhrozenByte opened this issue Nov 19, 2013 · 2 comments

Comments

@PhrozenByte
Copy link
Contributor

Review the following changes of klaaspeter/achievo:

@perryfaro
Copy link

@PhrozenByte Is this still relevant?

@PhrozenByte
Copy link
Contributor Author

Yes, I neither speak french nor slovak. The _registerDependees() changes can be merged after someone reviewed the correct functionality. I don't think the changes are working: the first commit registers a callback to $this->_registerDependees(), but neither basereport nor atkNode (= $this) defines this method. Besides _registerDependees() does something completely different than addDependency(). Have a look at atkAttribute::addDependee() of ATK 6.4.4 and current ATK dev as well as at atkAttribute::_registerDependees() of ATK 6.4.4 and atkAttribute::initDependencies() of current ATK dev. Maybe I miss something, but I don't think this works this way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants