Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: C++ improvents #128

Open
1 of 9 tasks
iopapamanoglou opened this issue Nov 7, 2024 · 0 comments
Open
1 of 9 tasks

Core: C++ improvents #128

iopapamanoglou opened this issue Nov 7, 2024 · 0 comments
Assignees
@iopapamanoglou

Comments

@iopapamanoglou
Copy link
Contributor

Feature Request

  • make everything const
  • fix leakage
    • fix cyclic shared ptr
  • be careful with reusing G
    • just use Module everywhere
  • revisit factories
    • maybe better to just override init to return shared_ptr?
    • see also nb::cast

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iopapamanoglou iopapamanoglou self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iopapamanoglou iopapamanoglou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iopapamanoglou