Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake improvement -- using pkg-find to find the libraries #1797

Open
mcuee opened this issue Apr 28, 2024 · 2 comments
Open

CMake improvement -- using pkg-find to find the libraries #1797

mcuee opened this issue Apr 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mcuee
Copy link
Collaborator

mcuee commented Apr 28, 2024

From the comment by @Youw here.

Yeap, this is the reason:

For libusb project, we usually recommend using pkg-config to find libusb.h and not to use libusb-1.0/libusb.h in any case.
https://github.com/avrdudes/avrdude/blob/main/src/avrftdi_private.h

It is not enough to install pkg-config. One must explicitly use it to find a package.

The propper way would be to remove things like find_library(HAVE_LIBUSB_1_0 ...) and similar nonsense with a propper use of cmake/pkg-config, e.g. in a similar way like HIDAPI does it.

@mcuee mcuee added the enhancement New feature or request label Apr 28, 2024
@mcuee
Copy link
Collaborator Author

mcuee commented Apr 28, 2024

@ndim

In case you continue the work on the CMake improvement along with autotools improvement, maybe you want to take a look at the above recommendations. Thanks.

@ndim
Copy link
Contributor

ndim commented Jul 31, 2024

Now that the gpiod support requires pkg-config logic anyway, we can jump on board completely, both on the cmake and on the automake side.

Both for finding our own dependencies and for installing a libavrdude-2.pc alongside libavrdude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants