Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a URL is entered for the target site (production or staging), convert it to relative, automatically #82

Open
pmuir opened this issue Oct 25, 2013 · 5 comments

Comments

@pmuir
Copy link
Contributor

pmuir commented Oct 25, 2013

No description provided.

@LightGuard
Copy link
Member

Does this have to do with links? I'm not sure the context here.

@pmuir
Copy link
Contributor Author

pmuir commented Oct 25, 2013

Right, if someone enters a link with a href of http://www.jboss.org/foo/bar, we should alter (or offer to fix it?) it to a relative URL ../foo/bar (for example)

@LightGuard
Copy link
Member

I think site assets should be absolute links, but page links (and
downloads) should probably relative. Wes, thoughts?

On Fri, Oct 25, 2013 at 2:53 PM, Pete Muir [email protected] wrote:

Right, if someone enters a link with a href of
http://www.jboss.org/foo/bar, we should alter (or offer to fix it?) it to
a relative URL ../foo/bar (for example)


Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-27124783
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Oct 25, 2013

If they are absolute links to images, we won't be able to preview images that haven't been pushed yet. Can we?

@pmuir
Copy link
Contributor Author

pmuir commented Oct 26, 2013

I talked to @LightGuard about this towards the end of the meeting, and I think the idea is that page specific resources should be relative links, but site resources (such as CSS files, font files) should be absolute URLs (we tend to want to put these on static.jboss.org anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants