Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate preview asynchronously #86

Open
pmuir opened this issue Oct 25, 2013 · 4 comments
Open

Regenerate preview asynchronously #86

pmuir opened this issue Oct 25, 2013 · 4 comments

Comments

@pmuir
Copy link
Contributor

pmuir commented Oct 25, 2013

Once the save is complete, return control to the browser immediately. Start the regeneration, and then update it when complete, e.g. using long poll.

@wesbos
Copy link
Member

wesbos commented Oct 25, 2013

@LightGuard we will need a callback or something when the save has taken place in addition to the current site being regenerated.

@LightGuard
Copy link
Member

Why do we need a callback? Could we not add a button that says "View Site
Preview"? Or maybe just modify the current "Open Preview" button to

  1. Check if the new window is open
  2. Refresh the /preview/:repo/ URL so the user is back at the top fo the
    site

Would that work for us?

On Fri, Oct 25, 2013 at 1:11 PM, Wes Bos [email protected] wrote:

@LightGuard https://github.com/LightGuard we will need a callback or
something when the save has taken place in addition to the current site
being regenerated.


Reply to this email directly or view it on GitHubhttps://github.com//issues/86#issuecomment-27118104
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Oct 25, 2013

But doesn't the current save button only come back when the site generation is done?

@LightGuard
Copy link
Member

Currently, but we're going to change that.

On Fri, Oct 25, 2013 at 2:44 PM, Wes Bos [email protected] wrote:

But doesn't the current save button only come back when the site
generation is done?


Reply to this email directly or view it on GitHubhttps://github.com//issues/86#issuecomment-27124226
.

Jason Porter
http://en.gravatar.com/lightguardjp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants