Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use proper label for node role #7069

Open
randych-gilad opened this issue Sep 25, 2024 · 2 comments
Open

Cannot use proper label for node role #7069

randych-gilad opened this issue Sep 25, 2024 · 2 comments
Labels
feature New feature or request needs-triage Issues that need to be triaged

Comments

@randych-gilad
Copy link

Description

What problem are you trying to solve?
Lens can only display Roles as node-role.kubernetes.io/<role>, but due to label domain "kubernetes.io" is restricted I cannot set it, while I can normally with launch template
How important is this feature to you?
It's not great that I need to jump between node list and node claim list to get the idea of which nodes are from which node pool.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@randych-gilad randych-gilad added feature New feature or request needs-triage Issues that need to be triaged labels Sep 25, 2024
@2rs2ts
Copy link

2rs2ts commented Oct 1, 2024

👍 Please also allow kubernetes.io/role=<role>. kubectl get node respects this label too.

@2rs2ts
Copy link

2rs2ts commented Oct 2, 2024

Looks like this is a duplicate of #1941 but I will link my comment from that thread, since I think it's pretty clear that given that the docs actually encourage you to set this label, karpenter should let you do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request needs-triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants