Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no mention of VC++ redist 2015 /runtime/ dependency #371

Closed
mikelpr opened this issue Nov 11, 2022 · 2 comments
Closed

no mention of VC++ redist 2015 /runtime/ dependency #371

mikelpr opened this issue Nov 11, 2022 · 2 comments
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue

Comments

@mikelpr
Copy link

mikelpr commented Nov 11, 2022

README mentions Visual Studio C++ 2015 dependency for building but doesn't mention that the user needs VC++ 2015 runtime dependency installed for applications that use aws-crt-nodejs. This is not obvious as the import of aws-crt fails with a process.dlopen error that says it couldn't find the aws-crt-nodejs library at the path it actually exists at (*/win32-x64/aws-crt-nodejs.node) and doesn't mention at all that it requires VCRUNTIME140.dll, which I found out scanning aws-crt-nodejs.node with https://github.com/lucasg/Dependencies

@mikelpr mikelpr changed the title no mention of VC++ redist 2015 /runtime&/ no mention of VC++ redist 2015 /runtime/ dependency Nov 11, 2022
@jmklix jmklix added documentation This is a problem with documentation. p3 This is a minor priority issue labels Nov 29, 2023
@jmklix
Copy link
Member

jmklix commented Mar 28, 2024

We believe this requirement is included when specifying Visual Studio C++ 2015. Please let us know if you think any other dependencies are not clearly listed

@jmklix jmklix closed this as completed Mar 28, 2024
@mikelpr
Copy link
Author

mikelpr commented Apr 6, 2024

@jmklix as I mentioned, it is only specified for building, not for runtime. if we were to take what is specified as build deps for runtime too, we would also be expecting npm and cmake on user's machines and that is not the case at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants