-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade axios to 1.x #464
Comments
There isn't a clear upgrade path for axios given our node baseline (10.16); there are complexities with CommonJS vs. ES modules that seem to complicate the task. We could consider a PR that updated the version such that all CI passes. Another alternative is to move off of axios altogether but that would require a stronger external impetus. |
axios 1.x support both cjs and esm |
That may be the case, but I did not have any luck getting an upgrade-to-latest working across our node 10 and 12 CI. The best way forward is likely to bump our minimum node version to 14, freeing up our ability to update both cmake-js and axios. |
There are now CVEs for that version of axios: https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459 Node 10 and 12 haven't had security support for at least a year and a half. Even 14 stopped receiving security updates half a year ago. Node 18 is the oldest still supported version of node at the moment. |
My personal view is that middleware libraries shouldn't dictate minimum versions (especially of the runtime itself) beyond what's absolutely necessary. That being said, I will try and do the bump to 14 (with updates to axios and cmake-js) sometime this next week. |
This is complete as of v1.19.0 |
Describe the feature
current axios version is
0.24.0
, latest version is1.4.0
. please upgrade to latest.Use Case
My app use latest axios version 1.x, but this package use 0.x, cause bundle axios repeatly.
Acknowledgements
The text was updated successfully, but these errors were encountered: