Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing fixture data for tests/test_examples/test_sir_python.py? #90

Open
muxator opened this issue Sep 16, 2024 · 1 comment
Open

missing fixture data for tests/test_examples/test_sir_python.py? #90

muxator opened this issue Sep 16, 2024 · 1 comment

Comments

@muxator
Copy link

muxator commented Sep 16, 2024

The test test_sir_w_breaks() assumes that a file named tests/fixtures/data/test_sir_w_breaks_python.npy is committed in the repo, but the file is not there:

def test_sir_w_breaks() -> None:
"""Test the 'SIR_w_breaks' function in examples/models/sir/sir_python.py."""
expected_output = np.load(
TEST_DIR / "fixtures" / "data" / "test_sir_w_breaks_python.npy",
)

tests/test_examples/test_sir_python.py was introduced in d7a3e84 (@marcofavoritobi). It contained two tests:

  • test_sir(), which references test_sir_python.npy that was (correctly) committed
  • test_sir_w_breaks() which references a missing file. Probably an oversight?
@muxator
Copy link
Author

muxator commented Sep 16, 2024

Discovered while working at #89.

Test execution fails with (ephemeral log: https://github.com/bancaditalia/black-it/actions/runs/10880576538/job/30187693768?pr=89#step:6:591):

E      FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/black-it/black-it/tests/fixtures/data/test_sir_w_breaks_python.npy'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant