Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate changing "Base" Class into a Trait #103

Open
JJJ opened this issue May 13, 2021 · 2 comments
Open

Investigate changing "Base" Class into a Trait #103

JJJ opened this issue May 13, 2021 · 2 comments
Labels
component-base The Base class type-request New feature or request workflow-needs-research Needs to be researched

Comments

@JJJ
Copy link
Collaborator

JJJ commented May 13, 2021

See: https://www.php.net/manual/en/language.oop5.traits.php

This would allow the Base trait be extended more easily, while also eliminating some confusion around including, forking, renaming, etc...

@JJJ JJJ added type-request New feature or request component-base The Base class labels May 13, 2021
@alexstandiford
Copy link
Collaborator

If we take this route, I wonder if it makes sense to break it up into more than one?

@JJJ
Copy link
Collaborator Author

JJJ commented May 28, 2021

Related: #69, #39.

@JJJ JJJ added the workflow-needs-research Needs to be researched label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-base The Base class type-request New feature or request workflow-needs-research Needs to be researched
Projects
None yet
Development

No branches or pull requests

2 participants