-
Notifications
You must be signed in to change notification settings - Fork 25
/
R002.go
53 lines (42 loc) · 1.3 KB
/
R002.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
// Package R002 defines an Analyzer that checks for
// ResourceData.Set() calls using * dereferences
package R002
import (
"go/ast"
"golang.org/x/tools/go/analysis"
"github.com/bflad/tfproviderlint/passes/commentignore"
"github.com/bflad/tfproviderlint/passes/helper/schema/resourcedatasetcallexpr"
)
const Doc = `check for ResourceData.Set() calls using * dereferences
The R002 analyzer reports likely extraneous uses of
star (*) dereferences for a Set() call. The Set() function automatically
handles pointers and * dereferences without nil checks can panic.`
const analyzerName = "R002"
var Analyzer = &analysis.Analyzer{
Name: analyzerName,
Doc: Doc,
Requires: []*analysis.Analyzer{
resourcedatasetcallexpr.Analyzer,
commentignore.Analyzer,
},
Run: run,
}
func run(pass *analysis.Pass) (interface{}, error) {
ignorer := pass.ResultOf[commentignore.Analyzer].(*commentignore.Ignorer)
sets := pass.ResultOf[resourcedatasetcallexpr.Analyzer].([]*ast.CallExpr)
for _, set := range sets {
if ignorer.ShouldIgnore(analyzerName, set) {
continue
}
if len(set.Args) < 2 {
continue
}
switch v := set.Args[1].(type) {
default:
continue
case *ast.StarExpr:
pass.Reportf(v.Pos(), "%s: ResourceData.Set() pointer value dereference is extraneous", analyzerName)
}
}
return nil, nil
}