Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Check: Extraneous Zero Value Checking With GetOk #196

Open
bflad opened this issue Aug 20, 2020 · 0 comments
Open

New Check: Extraneous Zero Value Checking With GetOk #196

bflad opened this issue Aug 20, 2020 · 0 comments
Labels
ast AST Handling check/resource Resource Check new-check New Lint Check

Comments

@bflad
Copy link
Owner

bflad commented Aug 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Using the (*helper/schema.ResourceData).GetOk() receiver method will automatically check against the zero-value for the type, e.g.

  • bool against false
  • int against 0
  • string against ""

Capture when the resource logic immediately performs the same conditional.

New or Affected Checks(s)

  • R###

Flagged Provider Code

if v, ok := d.GetOk("attr"); ok && v.(bool) { // ...

if v, ok := d.GetOk("attr"); ok && v.(int) != 0 { // ...

if v, ok := d.GetOk("attr"); ok && v.(string) != "" { // ...

Passing Provider Code

if v, ok := d.GetOk("attr"); ok { // ...
@bflad bflad added ast AST Handling new-check New Lint Check check/resource Resource Check labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast AST Handling check/resource Resource Check new-check New Lint Check
Projects
None yet
Development

No branches or pull requests

1 participant