Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/minio] Fix invalid sts template in distributed mode #30187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Aegdesil
Copy link

@Aegdesil Aegdesil commented Nov 4, 2024

Description of the change

Fixes the invalid statefulset template when deploying Minio in distributed mode.

Benefits

Chart can now be deployed in distributed mode again.

Possible drawbacks

/

Applicable issues

Additional information

/

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! Looking at the changelog merge error, it seems that you may need to bump again the patch version. Could you do it?

@Aegdesil Aegdesil force-pushed the fix-minio-sts-persistence-selector branch from 9a5a2ec to 868e087 Compare November 5, 2024 09:17
@Aegdesil
Copy link
Author

Aegdesil commented Nov 5, 2024

Done @javsalgar, can you have another look ?

bitnami-bot and others added 2 commits November 5, 2024 09:24
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Nov 5, 2024
@github-actions github-actions bot removed the triage Triage is needed label Nov 5, 2024
@github-actions github-actions bot removed the request for review from javsalgar November 5, 2024 15:25
@github-actions github-actions bot requested a review from fmulero November 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress minio verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/minio] Templating error in latest minio chart
5 participants