Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usused direct dependencies on webpack #6461

Open
trivikr opened this issue Nov 17, 2024 · 3 comments · May be fixed by #6466
Open

Remove usused direct dependencies on webpack #6461

trivikr opened this issue Nov 17, 2024 · 3 comments · May be fixed by #6466
Labels
feature-request A request for a new feature

Comments

@trivikr
Copy link
Contributor

trivikr commented Nov 17, 2024

Describe the Feature

The direct dependencies for webpack were added on migrating from "react-scripts" in d6ec627.
However, they weren't removed when we target moved to expo in #288

The following dependencies can be removed as they're imported elsewhere:

  • babel-loader
    • Now imported from @expo#webpack-config#babel-loader
    • No direct use in webpack config.
  • babel-plugin-react-native-web
    • Now imported from @expo#babel-preset-expo#babel-plugin-react-native-web
    • No direct use in webpack config.
  • html-webpack-plugin
    • Now imported from @expo#webpack-config#html-webpack-plugin
    • No direct use in webpack config
  • webpack
    • Now imported from @expo#webpack-config#webpack
  • webpack-dev-server
    • Now imported from @expo#webpack-config#webpack-dev-server

Following dependencies can be removed as they're no longer used:

  • @tsconfig/react-native
  • url-loader
  • webpack-cli

Attachments

No response

Describe Alternatives

No response

Additional Context

No response

@trivikr trivikr added the feature-request A request for a new feature label Nov 17, 2024
@gaearon
Copy link
Contributor

gaearon commented Nov 17, 2024

If you remove them, please do verify that the build actually works — see #6459 for context.

@trivikr
Copy link
Contributor Author

trivikr commented Nov 17, 2024

Thanks for providing a fix!

I just created a bug report when testing removal of webpack dependencies at #6462

@trivikr
Copy link
Contributor Author

trivikr commented Nov 17, 2024

please do verify that the build actually works

ToDo: Run yarn web and verify whenever this task is taken up.
Instructions: https://github.com/bluesky-social/social-app/blob/main/docs/build.md#running-web-app

@trivikr trivikr linked a pull request Nov 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants