Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usused direct dependencies on 'webpack' #6466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove usused direct dependencies on 'webpack' #6466

wants to merge 2 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 17, 2024

Fixes: #6461

Ensured that yarn web runs with a clean build, and website is accessible at http://localhost:19006/

$ git clean -dfx && yarn

$ yarn web
yarn run v1.22.19
$ expo start --web
Starting project at /Users/trivikram/workspace/social-app
Starting Metro Bundler
Starting Webpack on port 19006 in development mode.
...

Verified that there's no babel-loader folder in node_modules/.cache

$ ls node_modules/.cache      
web

@trivikr trivikr force-pushed the remove-webpack branch 2 times, most recently from 245e65c to 6fead70 Compare November 17, 2024 18:09
gaearon
gaearon reviewed Nov 17, 2024
View reviewed changes
package.json
@@ -221,7 +220,6 @@
"@react-native/typescript-config": "^0.74.1",
"@testing-library/jest-native": "^5.4.1",
"@testing-library/react-native": "^11.5.2",
"@tsconfig/react-native": "^2.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsconfig.json was extended from @tsconfig/react-native in d6ec627#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0

It was changed to @react-native/typescript-config in 93f5bb3#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R2

@gaearon
Copy link
Contributor

gaearon commented Nov 17, 2024

This would need a rebase.

@trivikr
Copy link
Contributor Author

trivikr commented Nov 17, 2024

Rebase done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usused direct dependencies on webpack
2 participants
@trivikr @gaearon