Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tailwind 1.2+ [Feature Request] #52

Open
sanishkr opened this issue Feb 6, 2020 · 11 comments
Open

Support for tailwind 1.2+ [Feature Request] #52

sanishkr opened this issue Feb 6, 2020 · 11 comments

Comments

@sanishkr
Copy link

sanishkr commented Feb 6, 2020

Please add support for new utilities introduced with tailwind 1.2 like css grid, transform, etc..

@axe312ger
Copy link

axe312ger commented Feb 7, 2020

Just digging into the source, I guess we easily could create a PR, as I guess we only have to extend these files:

https://github.com/bradlc/babel-plugin-tailwind-components/blob/master/src/static-styles.js
https://github.com/bradlc/babel-plugin-tailwind-components/blob/master/src/dynamic-styles.js

Edit:

These are the files from master, v1 work was done in next. There are many new files, but these style definitions seem to stay the same -> https://github.com/bradlc/babel-plugin-tailwind-components/blob/next/src/

@sanishkr
Copy link
Author

sanishkr commented Feb 7, 2020

Yeah, right. Please confirm @bradlc

@sanishkr
Copy link
Author

Alright, I'm going in.
Starting with staticStyles display section, and will go in that order and keep updating as in latest v1.2 of tw.

It will be great if more people join in and help, maybe take on dynamicStyles

Note: I'm not sure if updating only these 2 files will do the trick. Hope so.

@ben-rogerson
Copy link

ben-rogerson commented Feb 10, 2020

There are features that have been introduced that require some major changes to the selector matching system in this package.
I'm releasing a new package soon that has a high degree of support for the new v1.2 features along with a few extras.
Follow for announcements

@sanishkr
Copy link
Author

Thanks @ben-rogerson , shall wait for it then. When can this plugin be released?
It will be great if you keep the similar tw`` literal format as in this plugin.

And you mean to say tailwindcss v1.2 features, right?

@ben-rogerson
Copy link

I'm planning on the first release in two weeks around Feb 26th.
I've chosen to use babel-plugin-tailwind-components as a solid base so it'll include the same features, and the macro tw will definitely be kept 👍

Correct, I meant Tailwind 1.2 (I'll edit that).

@ben-rogerson
Copy link

ben-rogerson commented Feb 19, 2020

Hey all, I've just released my plugin Twin 🎉

@sanishkr
Copy link
Author

Thank you so much. @ben-rogerson

@fvanwijk
Copy link

Isn't it possible to get the features from tailwindcss instead of having to keep this plugin up to date manually?

@sanishkr
Copy link
Author

It's only possible to do so up to a certain extent. I guess, @ben-rogerson is doing that in twin.macro.

@sanishkr sanishkr changed the title Support for tailwind 1.2 [Feature Request] Support for tailwind 1.2+ [Feature Request] Apr 30, 2020
@lukasluecke
Copy link

There is something in progress at ben-rogerson/twin.macro#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants