Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] run benchmarks on latest development branch of tools #75

Open
alessandrofelder opened this issue Jan 8, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@alessandrofelder
Copy link
Member

Is your feature request related to a problem? Please describe.
While this repo is mainly user-facing, and should provide users with examples that run with the latest version of the brainglobe metapackage, the benchmarks should run on the development versions of tools to warn of problems early.

Describe the solution you'd like
The benchmarks should run on the development versions of tools to warn of problems early.

Describe alternatives you've considered
None yet

Additional context
Started discussion of this in #72

@alessandrofelder alessandrofelder added the enhancement New feature or request label Jan 8, 2024
@adamltyson
Copy link
Member

This could just be done with a separate requirements file right? Just listing e.g. git+https://github.com/brainglobe/cellfinder?

@alessandrofelder
Copy link
Member Author

Presumably, yes... I would guess there's a simple solution at least.

@willGraham01
Copy link
Collaborator

willGraham01 commented Jan 8, 2024

I believe (and @sfmig will correct me if I'm wrong) but asv attempts to build the package wheels, then install from said wheel file into it's testing environment, from pyproject.toml.

As such, it gathers dependencies from the package metadata and fetches those dependencies from the specified channels. This is why we have the asv_requirements optional dependency for the package to force asv to find everything it needs, but users don't. You can set the channels that it searches for dependencies, but that doesn't extend to GitHub.

But I believe we can hack around this by overwriting the "build command" in asv_conf.json. Said build command will just happen to include pip install -r asv_reqs_from_github.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants