Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in ChromeImporterCanImport #15895

Closed
iefremov opened this issue May 17, 2021 · 1 comment · Fixed by brave/brave-core#25758
Closed

Crash in ChromeImporterCanImport #15895

iefremov opened this issue May 17, 2021 · 1 comment · Fixed by brave/brave-core#25758
Assignees
Labels
crash OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@iefremov
Copy link
Contributor

iefremov commented May 17, 2021

https://brave.sp.backtrace.io/p/brave/explore?time=month&filters=((callstack.functions%2Ccontains%2CChromeImporterCanImport)%2C_deleted%3D0%2Cptype%3Dbrowser)&aggregations=((uname.sysname%2Cdistribution)%2C(callstack%2Chead))&

[ 00 ] ChromeImporterCanImport(base::FilePath const&, unsigned short*)
[ 01 ] (anonymous namespace)::AddChromeToProfiles(std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> >*, base::ListValue*, base::FilePath const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
[ 02 ] (anonymous namespace)::DetectChromeProfiles(std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> >*)
[ 03 ] (anonymous namespace)::DetectSourceProfilesWorker(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool)
[ 04 ] base::internal::Invoker<base::internal::BindState<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > (*)(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool>, std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > ()>::RunOnce(base::internal::BindStateBase*)
[ 05 ] void base::internal::ReturnAsParamAdapter<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > >(base::OnceCallback<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > ()>, std::__1::unique_ptr<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> >, std::__1::default_delete<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > > >*)
[ 06 ] base::internal::Invoker<base::internal::BindState<void (*)(base::OnceCallback<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > ()>, std::__1::unique_ptr<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> >, std::__1::default_delete<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > > >*), base::OnceCallback<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > ()>, std::__1::unique_ptr<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> >, std::__1::default_delete<std::__1::vector<importer::SourceProfile, std::__1::allocator<importer::SourceProfile> > > >*>, void ()>::RunOnce(base::internal::BindStateBase*)
[ 07 ] base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply(base::(anonymous namespace)::PostTaskAndReplyRelay)
[ 08 ] base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*)
[ 09 ] <name omitted>
[ 10 ] base::internal::TaskTracker::RunContinueOnShutdown(base::internal::Task*)
[ 11 ] base::internal::TaskTracker::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&)
[ 12 ] base::internal::TaskTrackerPosix::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&)
[ 13 ] base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource)
[ 14 ] base::internal::WorkerThread::RunWorker()
[ 15 ] base::internal::WorkerThread::RunPooledWorker()
[ 16 ] base::(anonymous namespace)::ThreadFunc(void*)
[ 17 ] _pthread_start
[ 18 ] thread_start
[ 19 ] 0x10a1962a0
@iefremov
Copy link
Contributor Author

iefremov commented Oct 2, 2024

For QA: I've markes it as Qa/No beacuse the fix is straightforward and covered with tests. But it can be tested by trying to import a profile with manually corrupted Preferences or Secure Preferences: (1) make this file not valid json (2) adding an extension that is not a json dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants