Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR130] Crash at Content Filtering #41402

Open
1 of 6 tasks
AlexeyBarabash opened this issue Oct 4, 2024 · 0 comments · May be fixed by brave/brave-core#25812
Open
1 of 6 tasks

[CR130] Crash at Content Filtering #41402

AlexeyBarabash opened this issue Oct 4, 2024 · 0 comments · May be fixed by brave/brave-core#25812
Assignees
@AlexeyBarabash
Labels
crash OS/Android Fixes related to Android browser functionality QA/Test-Plan-Specified QA/Yes regression release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Regression after CR130.

Browser crashes when open Content Filtering.

java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
at androidx.fragment.app.Fragment.performAttach(Fragment.java:3075)
...

Steps to reproduce

App menu => Settings => Brave Shields & privacy => Content Filtering

Actual result

crash

Expected result

no crash

Reproduces how often

Easily reproduced

Brave version

Own-built Nightly with CR130.
1.72.61

Device

any

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@AlexeyBarabash AlexeyBarabash added the OS/Android Fixes related to Android browser functionality label Oct 4, 2024
@AlexeyBarabash AlexeyBarabash self-assigned this Oct 4, 2024
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Oct 4, 2024
@AlexeyBarabash
Fixed crash at Content Filtering
1760689 
fixes brave/brave-browser#41402

Crash happened at app menu => Settings => Brave Shields & privacy => Content Filtering.

Tombstone
```
java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
```

Upstream had added a new place to create Intent for Settings activity.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d4af6a2c4ccc6427aa7df0f2beacf61793459e66

	[Settings] Introduce a central place to construct intents

	SettingsIntentUtil becomes the central place to construct intents
	launching the settings activity.

	Bug: b/356743945
	Change-Id: Id6988af4a182fe6603bb02c9dae8b2ac48f80fed
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5832868
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Oct 4, 2024
@AlexeyBarabash
Fixed crash at Content Filtering
fb65475 
fixes brave/brave-browser#41402

Crash happened at app menu => Settings => Brave Shields & privacy => Content Filtering.

Tombstone
```
java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
```

Upstream had added a new place to create Intent for Settings activity.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d4af6a2c4ccc6427aa7df0f2beacf61793459e66

	[Settings] Introduce a central place to construct intents

	SettingsIntentUtil becomes the central place to construct intents
	launching the settings activity.

	Bug: b/356743945
	Change-Id: Id6988af4a182fe6603bb02c9dae8b2ac48f80fed
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5832868
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Oct 4, 2024
@AlexeyBarabash
Fixed crash at Content Filtering
3b25611 
fixes brave/brave-browser#41402

Crash happened at app menu => Settings => Brave Shields & privacy => Content Filtering.

Tombstone
```
java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
```

Upstream had added a new place to create Intent for Settings activity.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d4af6a2c4ccc6427aa7df0f2beacf61793459e66

	[Settings] Introduce a central place to construct intents

	SettingsIntentUtil becomes the central place to construct intents
	launching the settings activity.

	Bug: b/356743945
	Change-Id: Id6988af4a182fe6603bb02c9dae8b2ac48f80fed
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5832868
@AlexeyBarabash AlexeyBarabash linked a pull request Oct 4, 2024 that will close this issue
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
crash OS/Android Fixes related to Android browser functionality QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed crash at Content Filtering brave/brave-core
1 participant
@AlexeyBarabash