Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support anonymous factory #22

Closed
terasaka2k opened this issue Apr 14, 2013 · 2 comments
Closed

Support anonymous factory #22

terasaka2k opened this issue Apr 14, 2013 · 2 comments

Comments

@terasaka2k
Copy link

It would be nice to support anonymous factories.
Currently implicit injections like below fails because it is not converted to explicit ones.

$httpProvider.interceptors.push(function($someService) { ... })
@btford
Copy link
Owner

btford commented May 1, 2013

This seems like a bit more work than it's worth, but I'm willing to consider it for a future release.

olov added a commit to olov/ng-annotate that referenced this issue May 13, 2014
@olov
ngmin issues that just works in ng-annotate: btford/ngmin#91, btford/…
7dbcc7c 
…ngmin#89, btford/ngmin#87, btford/ngmin#85, btford/ngmin#78, btford/ngmin#77, btford/ngmin#73, btford/ngmin#70, btford/ngmin#64, btford/ngmin#63, btford/ngmin#61, btford/ngmin#59, btford/ngmin#57, btford/ngmin#56, btford/ngmin#54, btford/ngmin#50, btford/ngmin#46, btford/ngmin#43, btford/ngmin#42, btford/ngmin#37, btford/ngmin#35, btford/ngmin#22
@eddiemonge
Copy link
Collaborator

Please try https://github.com/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https://github.com/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddiemonge @btford @terasaka2k