Support minification of $routeProvider resolve functions

[Siyfion]

At the moment the only part of my code that doesn't minify properly are my resolve functions in my $routeProvider.when() statements.

It would be nice to see these supported. 👍

[btford]

+1; I'm currently re-writing ngmin to use Astral, but this will be the next feature I add.

[meenie]

I just realised this myself about 30 mins ago and had to change all of our resolve functions heh.

@btford, thanks a ton for your work on this, I really appreciate it 👍

[spacenick]

That would be dope for "any" resolve actually! (I'm using ui-router and $stateProvider for my routes)
Cheers @btford this tool is insane.

[lpaulger]

+1

[mlegenhausen]

+1

[thesamet]

+1

[btford]

Added a test here: https://github.com/btford/ngmin/blob/master/test/route-provider.js#L24

If you have any other cases, please send a PR. Implementation to follow soon.

[btford]

Closed via btford/astral-angular-annotate@e157310

Reinstall ngmin to get the latest relevant dependency with the fix.

[Siyfion]

@btford Is this worthy of a up-rev? That way we can just update from bower. ❓

[btford]

You don't update ngmin via bower.

[Siyfion]

Eak, npm even :/
—
Sent from Mailbox for iPhone

On Tue, Jul 2, 2013 at 4:47 PM, Brian Ford [email protected]
wrote:

You don't update ngmin via bower.

Reply to this email directly or view it on GitHub:
#35 (comment)

[btford]

If you update via npm you should get the new updated dependencies. There's no need to bump the version.

[thesamet]

The test you referred to (https://github.com/btford/ngmin/blob/master/test/route-provider.js#L24) does not handle resolve functions.

I have added an example of (a failing) test case:

thesamet@6171c7b

[Siyfion]

@btford And I remember what I meant now, grunt-ngmin is currently pulling ngmin in for me, however it's pulling in v0.4.0 which obviously doesn't have this fix (as yet). Is it possible we could have an interim update to grunt-ngmin?

[danieljsinclair]

I could do with this

[mlegenhausen]

There is no support for the resolve object. I added it to the astral annotations.

btford/astral-angular-annotate#2

[homburg]

This issue does not seem to be fixed yet. See #35 (comment)

[mlegenhausen]

It isn't. It only works for inline controller definition as shown in the tests.

[homburg]

Are there plans for solving this or including your pull request?

[mlegenhausen]

I haven't get any feedback yet. But you can use my fork and install it via the git url.

[homburg]

Thank you. I have added your fork to my npm dependencies and it solves the
issue perfectly.

[mboudreau]

+1. Please fix this. This is completely stopping us from a production build.

[btford]

This is completely stopping us from a production build.

You do know that you can add the annotation yourself, right? There's no reason this should ever hold up anything.

[mlegenhausen]

@mboudreau For now modify your package.json as follows:

devDependencies: {
  "astral-angular-annotate": "git+https://github.com/werk85/astral-angular-annotate.git"
  ...
}

and your problems are solved until the fix is validated and accepted by @btford.

[mboudreau]

I tried that without success. It seems that the dependency doesn't seem to
override the ngmin dependency. Am I missing something?
On Sep 26, 2013 8:21 PM, "Malte Legenhausen" [email protected]
wrote:

@mboudreau https://github.com/mboudreau For now modify your package.jsonas follows:

devDependencies: {
"astral-angular-annotate": "git+https://github.com/werk85/astral-angular-annotate.git"
...
}

and your problems are solved until the fix is validated and accepted by
@btford https://github.com/btford.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-25157096
.

[mlegenhausen]

Uninstall grunt-ngmin or ngmin from your node_modules and install it again.

[mboudreau]

Awesome. Let me try that. Thanks bud.
On Sep 26, 2013 8:45 PM, "Malte Legenhausen" [email protected]
wrote:

Uninstall grunt-ngmin or ngmin from your node_modules and install it
again.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-25158310
.

[mboudreau]

Yeah, no dice, still not working even after uninstall, re-installing
astral-angular-annotate, and installing ngmin and grunt-ngmin afterwards...

On Thu, Sep 26, 2013 at 9:00 PM, Michel Boudreau
[email protected]:

Awesome. Let me try that. Thanks bud.
On Sep 26, 2013 8:45 PM, "Malte Legenhausen" [email protected]
wrote:

Uninstall grunt-ngmin or ngmin from your node_modules and install it
again.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-25158310
.

"If at first you don't succeed, use a bigger hammer." - Unofficial motto of
the Royal Electrical and Mechanical Engineers

[tlvince]

To confirm, when this lands, will it support ui-router $stateProvider controllers?

[paulmelnikow]

+1

[mlegenhausen]

@tlvince I don't think so. You will need to add your own annotation rules.

I think the best way would be a plugable annotation system, cause there are many more places where you need this stuff.

[szimek]

Is it already implemented in some unreleased version of ngmin or astral-angular-annotate?

[mlegenhausen]

@szimek add the dependency manually to your dependency list. Then ngmin will pick up the new one.

[mlegenhausen]

I think the main release this doesn't get resolved is that the annotation system needs to be more adaptable. There are so many other libraries out there that would benefit from annotation support e.g. ui-router. So ngmin should not be responsible for the minification support for all the libraries but should offer an extensible system.

[szimek]

@mlegenhausen I can agree with it, but it would be also great if the current non-extensible version of ngmin supported at least pure angular out of the box. It's already fixed and only a matter of merging a PR and releasing a new version. It doesn't conflict in any way with rewriting ngmin to support some kind of plugin system in the future.

[mlegenhausen]

Cause ngRoute is not a core component anymore the next step needs to be an extensible system. If you want to keep ngmin for the core this should not be resolved.

Making ngmin extensible shouldn't be a big problem. Maybe I find some time to solve this.

[szimek]

Right, I forgot ngRoute was removed from core in 1.2.0.

[mlegenhausen]

Done. Look at my pull request #61 and vote for it ;)

[eddiemonge]

Please try https://github.com/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https://github.com/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.