Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify suggestions #46

Open
rowanoulton opened this issue Sep 5, 2015 · 6 comments
Open

Classify suggestions #46

rowanoulton opened this issue Sep 5, 2015 · 6 comments

Comments

@rowanoulton
Copy link

It would be great if the output for each suggestion had a classification, for example:

[{
  suggestion: "omit 'So' from the beginning of sentences",
  type: 'so',
  index: 0, offset: 2
}, {
  suggestion: "'was stolen' is passive voice",
  type: 'passive-voice',
  index: 11, offset: 10
}]

At the moment, this can only be achieved by disabling all but a single check and running each individually. I'd love to use this linter to aggregate the various issues it checks for rather than implementing each linter individually. I think classifications would be helpful for such a use case.

@btford
Copy link
Owner

btford commented Oct 24, 2016

I think this is a reasonable request. PR welcome.

@oyeanuj
Copy link

oyeanuj commented Dec 22, 2016

@rowanoulton @btford Is this still something on the radar?

@AlexandreKilian
Copy link

since nothing has happened in the past 2,5 years, I assume nobody came up with a PR so far?

@AlexandreKilian
Copy link

I implemented it in a fork (https://github.com/qwill-app/write-good)… I'd also love to add a configuration option to enable/disable sorting suggestions by index (I need the checks in the order I configured them with, not ordered by index)… @btford should I do a PR with either sorting reenabled or configurable?

@rdmueller
Copy link
Contributor

any updated status on this? I also need the classification and don't want to rebuild it if there is already some code

@RichardLitt
Copy link
Collaborator

Please make a PR, @AlexandreKilian, with whatever sorting you think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants