Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused import bpfrpt_proptype_WindowScroller causing issue in Vite #1849

Open
reuben-gomesBP opened this issue Oct 7, 2024 · 4 comments
Open

Comments

@reuben-gomesBP
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

on vite this unused import seems to be throwing a build issue

Here is the diff that solved my problem:

diff --git a/node_modules/react-virtualized/dist/es/WindowScroller/utils/onScroll.js b/node_modules/react-virtualized/dist/es/WindowScroller/utils/onScroll.js
index d00f0f1..c8496e8 100644
--- a/node_modules/react-virtualized/dist/es/WindowScroller/utils/onScroll.js
+++ b/node_modules/react-virtualized/dist/es/WindowScroller/utils/onScroll.js
@@ -71,4 +71,3 @@ export function unregisterScrollListener(component, element) {
     }
   }
 }
\ No newline at end of file
-import { bpfrpt_proptype_WindowScroller } from "../WindowScroller.js";
\ No newline at end of file

This issue body was partially generated by patch-package.

@lxlyjss
Copy link

lxlyjss commented Oct 18, 2024

Me too!

@ysmood
Copy link

ysmood commented Oct 26, 2024

Does older version of react-virtualized not having this issue?

@reuben-gomesBP
Copy link
Author

i haven't been able to try with an older version

the issue mainly showed up when migrated to ViteJS

@rehangit
Copy link

rehangit commented Nov 1, 2024

  1. How come we are seeing the 9.22.5 in dependencies when it does not even exist? The latest version shown 9.22.4
  2. Can someone explain what this commit achieved? Because it seems to be the root cause of this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants