Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Full outer join scheduled & observed trips #2685

Closed
lauriemerrell opened this issue Jun 5, 2023 · 3 comments
Closed

Feature: Full outer join scheduled & observed trips #2685

lauriemerrell opened this issue Jun 5, 2023 · 3 comments
Assignees

Comments

@lauriemerrell
Copy link
Contributor

lauriemerrell commented Jun 5, 2023

To accomplish #2524, we would probably need to do the join that @evansiroky describes between fct_daily_scheduled_trips and fct_observed_trips in the warehouse. This ticket is intended to capture that portion of the request, because I decided that it would be too much to include in #2489.

Such a table comparing fct_daily_scheduled_trips and fct_observed_trips would need to have a full list of all trips from both tables. There are some things we will need to figure out how to capture:

  • For all scheduled trips: was there an RT feed for that schedule feed on that day? If so, was the trip present in the RT feed or not? (We want to distinguish between cases where there is no RT data for a trip because no RT feed exists vs. cases where an RT feed exists but the trip was missing from that RT feed.)
  • Do the times of any RT trip data align reasonably with what we expect from schedule? What do we do if not?
  • How do we handle cases where the route ID disagrees between schedule and RT?
@lauriemerrell
Copy link
Contributor Author

Ideally we would add some test to try to validate scheduled time vs. observed time and warn if they seem really out of whack

@lauriemerrell
Copy link
Contributor Author

I think this is still needed, though the work in #2489 made it a lot easier

@lauriemerrell
Copy link
Contributor Author

Closing as a duplicate of #2524 which outlines specific need for this table

@lauriemerrell lauriemerrell closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant