Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do on days with no files to check #62

Open
machow opened this issue Dec 13, 2021 · 2 comments
Open

Decide what to do on days with no files to check #62

machow opened this issue Dec 13, 2021 · 2 comments

Comments

@machow
Copy link
Contributor

machow commented Dec 13, 2021

Case 1: no files for a specific feed

On days where our files checks detect no files for a given feed, we currently do not show a blank column. For example, for itp id 294 in June, there should be a check on June 6th, but instead only 1 column is reported (June 20th).

image

This is because the itp id url error'd on June 6th (afaict a failure by the provider, since we have files for other feeds on that day).

Case 2: extractor failed

Another case of this occurs when the entire extraction script failed for a day being checked. This occurred on Sep 19th, so no reports have a Sep 19th column for file checks.

E.g. https://reports.calitp.org/gtfs_schedule/2021/09/10/index.html

To Decide

What should happen for the above cases? It seems like some options are...

  • We omit the columns as we are doing now
  • gtfs schedule fact daily feeds has information identifying case 1, so we could flag it. We could add a table recording days where the extractor failed. (and decide how we want to show this info).
  • we could interpolate and show a guess based on the files that existed on our last working extraction.
@evansiroky
Copy link
Member

Let's keep this issue open for now and proceed with omitting the columns for now. However, in a later effort, we'll completely close this out we should report information about where the error occurred (Cal-ITP error or publisher error).

@edasmalchi
Copy link
Member

V2 warehouse will include a table pointing to where errors like this occur, after migrating reports we can either incorporate directly or leverage @owades checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants