Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isRead in SMSMessage #6

Open
vikhari opened this issue Apr 13, 2018 · 0 comments
Open

isRead in SMSMessage #6

vikhari opened this issue Apr 13, 2018 · 0 comments

Comments

@vikhari
Copy link
Member

vikhari commented Apr 13, 2018

Issue ported from old casework github repo (issue 15).
Original author: casework

Why is there a separate isRead for SMSMessage? A regular message like "WhatsApp" could also have this field.

Response by sbarnum:

I don't know if there is any specific reason for it to be in SMSMessage specifically rather than in Message.

I believe it originally came from mapping the Hansken model in and Hansken has 'read' as a property of textMessage.

I would agree that it seems like it would be appropriate to move to Message.

If nobody disagrees we can add an issue to the UCO tracker proposing moving isRead from SMSMessage to Message property bundle and then deleting the SMSMessage property bundle since isRead is its only current property.

Response by casework:

Agreed.

@casework casework removed their assignment Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants