Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker instead of dbdeployer for local testing #187

Closed
daniel-nichter opened this issue Aug 26, 2023 · 2 comments · Fixed by #300
Closed

Use Docker instead of dbdeployer for local testing #187

daniel-nichter opened this issue Aug 26, 2023 · 2 comments · Fixed by #300
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@daniel-nichter
Copy link
Member

I propose we use Docker rather than dbdeployer because Docker is industry standard, and I bet it's far more common with developers than dbdeployer. It's also pretty easy to set up multiple version with Docker Compose.

If you agree, I'll do a PR later.

@morgo
Copy link
Collaborator

morgo commented Aug 26, 2023

I like dbdeployer, but I agree predicated on two assumptions:

@morgo morgo added the enhancement New feature or request label Aug 31, 2023
@morgo
Copy link
Collaborator

morgo commented May 22, 2024

Since this issue was created, dbdeployer has reached end of life. I'm adding the help-wanted tag to this issue.

@morgo morgo added the help wanted Extra attention is needed label May 22, 2024
sahilm added a commit to sahilm/spirit that referenced this issue Jun 24, 2024
TODO:
1. Tests with replicas
2. Docs (holding off docs till support is complete)

See also: cashapp#187
sahilm added a commit to sahilm/spirit that referenced this issue Jun 24, 2024
TODO:
1. Tests with replicas
2. Docs (holding off docs till support is complete)

See also: cashapp#187
sahilm added a commit to sahilm/spirit that referenced this issue Jun 24, 2024
TODO:
1. Tests with replicas
2. Docs (holding off docs till support is complete)

See also: cashapp#187
sahilm added a commit to sahilm/spirit that referenced this issue Jun 25, 2024
sahilm added a commit to sahilm/spirit that referenced this issue Jun 25, 2024
sahilm added a commit to sahilm/spirit that referenced this issue Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants