Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs link to incorrect context when accessed with a course context #177

Open
Peterburnett opened this issue Apr 26, 2023 · 1 comment
Open

Comments

@Peterburnett
Copy link
Contributor

Currently tool_crawler has reports linked from the course administartion menu for any particular course, which links to a report for the course, but the tabs are links to site context. This works for loading a single report, but attempting to use any of the tabs will result in a permission error.

[ ] Carry course context over between tabs

[ ] Hide "settings" and "status" tabs if you dont have permission to view them

@matthewhilton
Copy link
Contributor

matthewhilton commented Apr 27, 2023

Seems like this was done already in 4d4a455 - I can't recreate the issue.

I just set up this locally using:

  • Moodle 3.9
  • master crawler branch.
  • Created test course
  • Logging in as a teacher the tabs carry the &courseid parameter correctly, and also do not show the settings and status tabs (whereas the do If i'm a site admin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants