Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify step class names to "what they do", e.g. curl, cron (trigger?) #468

Open
keevan opened this issue Aug 6, 2022 · 1 comment
Open

Comments

@keevan
Copy link
Contributor

keevan commented Aug 6, 2022

One thing in particular I'd like to have happen is to change the class names from flow_this or connector_this (since they become redundant after the change described in #422, to simply curl_step or webservice_step.

As a developer I find it much easier to jump to the class based on how it's labelled normally. Any grouping / categorisation and file location is not the point here, and that can be done separately.

Note that the suffix isn't required but I do think it will reduce the amount of results that might show up when fzf-ing files in your IDE. Also the reason I didn't opt for step_curl and step_webservice is because my IDE currently prefers things in order otherwise there is no match (which I admit is slightly annoying). For other things like triggers, they could be labelled cron_trigger.php or grouped under another folder.

If you need them to be grouped visually in your local file browser, I would question to what benefit would that serve? Could that benefit be pushed to something like the step chooser page instead?

Happy to hear other suggestions and critique for this approach.

@brendanheywood
Copy link
Contributor

If it is already under a folder step then then step suffix can probably go as well

@keevan keevan changed the title Simplify step class names to "what they do" + "_step" Simplify step class names to "what they do", e.g. curl, cron (trigger?) Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants