Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test timeouts on PHP 8.1 #851

Open
matthewhilton opened this issue Nov 30, 2023 · 2 comments
Open

Test timeouts on PHP 8.1 #851

matthewhilton opened this issue Nov 30, 2023 · 2 comments
Assignees

Comments

@matthewhilton
Copy link
Contributor

matthewhilton commented Nov 30, 2023

I've got a strong suspicion that test timeouts we've been seeing on our CI server is a regression of #846

You can see even the Github CI actions for any php 8.1 simply dies, e.g.:

https://github.com/catalyst/moodle-tool_dataflows/actions/runs/6700057320/job/18205330143?pr=846

image

The PR I suspect caused it because of updates to the vendor i.e. composer libraries. Maybe a library version is bugged ?

@matthewhilton matthewhilton self-assigned this Nov 30, 2023
@matthewhilton
Copy link
Contributor Author

matthewhilton commented Nov 30, 2023

Running this locally on an 8.1 site, the dataflows tests seem to install correctly and run, except I get a spam of debug output:

1) tool_dataflows\local\execution\tool_dataflows_basic_execution_test::test_direct_and_out
This test printed output: 
Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211

Deprecated: ctype_digit(): Argument of type int will be interpreted as string in the future in /var/www/mdl41-dataflows/admin/tool/dataflows/vendor/symfony/yaml/Inline.php on line 211
...

@matthewhilton
Copy link
Contributor Author

matthewhilton commented Dec 1, 2023

Re-ran #846 actions with debugging output, and it seemed to spam a ton of deprecated messages (as in like 20k of them) and then gets stuck running the unit tests - something like an infinite loop or just too much output - not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant