Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate dialog, possible race condition? #459

Open
cmjdiff opened this issue Jun 18, 2024 · 2 comments
Open

Duplicate dialog, possible race condition? #459

cmjdiff opened this issue Jun 18, 2024 · 2 comments

Comments

@cmjdiff
Copy link

cmjdiff commented Jun 18, 2024

On some sites, CoM appears to handle a popup, only for another to appear. Not sure if this is some kind of race where it's not delivering a result quickly enough for the following resource, and then not checking again?

Screen recording: https://youtu.be/0MvCi8NiY0A

Example URLs here:
https://www.independent.co.uk/arts-entertainment/music/glastonbury/glastonbury-festival-legends-slot-sunday-shania-twain-b2557138.html
https://www.radiox.co.uk/festivals/glastonbury/who-played-glastonbury-legends-slot/

@svnhub
Copy link
Contributor

svnhub commented Jun 21, 2024

This happens when a bug is detected in a rule making it unable to completely fill the popup.
Somewhat oddly both of these work fine for me, indicating that this may be something else. What platform and browser are you using?

@cmjdiff
Copy link
Author

cmjdiff commented Jun 24, 2024

This is in Firefox (127.0.1) on Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants