Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Use gen_event for metrics and traces sending #133

Open
hauleth opened this issue Feb 8, 2019 · 9 comments · May be fixed by #136
Open

Use gen_event for metrics and traces sending #133

hauleth opened this issue Feb 8, 2019 · 9 comments · May be fixed by #136

Comments

@hauleth
Copy link
Contributor

hauleth commented Feb 8, 2019

No description provided.

@deadtrickster
Copy link
Member

why?

@hauleth
Copy link
Contributor Author

hauleth commented Feb 8, 2019

@deadtrickster because right now we are writing something similar on our own, and gen_event has some nice features that can help with management of the reporters/exporters, for example it provides support for deregistration or swapping listeners. Also this would provide interface similar to the 3rd pilar of observability - logs, which are using gen_event as logging dispatcher (both Elixir's Logger and Erlang's logger use that).

@tsloughter
Copy link
Member

I don't think logger uses gen_event.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 8, 2019

@tsloughter yeah, my bad.

@deadtrickster
Copy link
Member

can you throw some code? I still don't quite get the idea

@hauleth
Copy link
Contributor Author

hauleth commented Feb 10, 2019

@deadtrickster what do you mean by the code? You want PR with the migration to the gen_event?

@tsloughter
Copy link
Member

I think he just meant some code that'd show how it'd work.

I don't think it helps because as far as I know we'd still need the process for notifying the manager to kick off the events.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 10, 2019

@tsloughter yes, we would need, but it could be shared one, I am in the process of writing something that will show what I have in mind for that.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 10, 2019

Very rough and very WIP migration #136. However it shows the base idea how I would organise the code.

@hauleth hauleth linked a pull request Feb 12, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants