You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
All functions in oc_span are already present in the oc_trace. This will reduce public API of the library (good) but will slightly increase complexity of the oc_trace module (bad).
The text was updated successfully, but these errors were encountered:
@tsloughter in that case oc_trace should land "under" the oc_span, for example as oc_span_trace or something like that. Otherwise it can be confusing to the users about the difference between trace and span.
Yea, the extra link/4 is a mistake and can be removed from either of them.
I think we can fix this with docs in the modules to explain in oc_trace this is the module for interacting with your traces and that oc_span is really more of a private module, only to be used if you are writing something lower level, not instrumenting your own code.
Or actually marking it private so no docs are given for it.
Maybe there is also a better name for oc_trace but I don't think oc_span_trace is it.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
All functions in
oc_span
are already present in theoc_trace
. This will reduce public API of the library (good) but will slightly increase complexity of theoc_trace
module (bad).The text was updated successfully, but these errors were encountered: