Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Chai 3? #44

Open
chrisfosterelli opened this issue Jul 24, 2016 · 2 comments
Open

Support for Chai 3? #44

chrisfosterelli opened this issue Jul 24, 2016 · 2 comments

Comments

@chrisfosterelli
Copy link

Does this library work with Chai 3? After upgrading I now receive an error:

expect(res.body.data.comments).to.not.include.any.with.property('isHidden', true);

Leads to:

Fatal error: [ { _id: '8fa3d24de60f1a738a9d9dce',
    isHidden: false,
    isModerated: false } ] has no property 'isHidden'
@meeber
Copy link

meeber commented Jul 24, 2016

@chrisfosterelli I believe the problem is specifically with the any flag, which was added directly to Chai back in v2.0 via chaijs/chai#313, causing chai-things to skip over it here. I believe any of the aliases will still work in place of any: something, thing, item, one, or some.

@keithamus Do you want to make this as "PR Wanted" for fixing the any flag here using overwriteProperty?

@chrisfosterelli
Copy link
Author

@meeber Thanks, that workaround let's me upgrade to 3.5! I'll leave this issue open since it sounds like it is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants