Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure surveyor always created when user created #605

Open
lfilmeyer opened this issue Aug 16, 2024 · 0 comments
Open

Ensure surveyor always created when user created #605

lfilmeyer opened this issue Aug 16, 2024 · 0 comments

Comments

@lfilmeyer
Copy link
Contributor

I added the /admin/users endpoint which allows for the creation of an admin without surveyor data. However, we should always create a surveyor object when we create a user so that the user will show up on the Users page (which actually calls the GET /surveyors index). In a perfect world, the users and surveyors objects would probably be merged into 1 model, but that's a non-trivial amount of work to cleanup.

On the backend, we should validate the presence of surveyor on a user. It's currently a low priority issue because the frontend requires surveyor attributes, so in practice we are always creating surveyors with users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant