Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address inconsistencies in the traefik-forward-auth chart #37

Open
colearendt opened this issue Apr 20, 2022 · 0 comments
Open

Address inconsistencies in the traefik-forward-auth chart #37

colearendt opened this issue Apr 20, 2022 · 0 comments

Comments

@colearendt
Copy link
Owner

The traefik-forward-auth chart has some inconsistencies that we should back out. However, some are breaking changes, so should be done carefully:

  • serviceAnnotations vs. service.annotations
  • Not using helpers for selectorLabels, labels or fullName (the latter has a risk for long names)
  • Other config options missing that are normally in my charts...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colearendt