Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 test failures with python-3.8? #331

Open
juhp opened this issue Feb 1, 2020 · 8 comments
Open

2 test failures with python-3.8? #331

juhp opened this issue Feb 1, 2020 · 8 comments

Comments

@juhp
Copy link
Contributor

juhp commented Feb 1, 2020

When I build cmark (0.29.0 and 0.28.3) in the Fedora buildsystem there are two test failures:

The following tests FAILED:
	  2 - html_normalization (Failed)
	  5 - roundtriptest_executable (Failed)
Errors while running CTest
make: *** [Makefile:133: test] Error 8

Would it be possible to print out more details about the failures?

The previous successful Fedora build with the testsuite was in July 2019:
https://koji.fedoraproject.org/koji/packageinfo?packageID=21846
I am not sure what changed...

@juhp
Copy link
Contributor Author

juhp commented Feb 1, 2020

It seems to have started failing with Fedora 32 Rawhide: so my hunch is that this is due to python-3.8 possibly?

For now I will disable the tests in Fedora 32.

@jgm
Copy link
Member

jgm commented Feb 1, 2020

I don't know anything about this build system, but why don't you try building the normal way using cmake? This will tell you which tests failed.

@juhp
Copy link
Contributor Author

juhp commented Feb 7, 2020

Ah, I am building the usual way - you can ignore the word "buildsystem" in the initial comment.

@juhp juhp changed the title 2 test failures in Fedora buildsystem 2 test failures with python-3.8? Feb 7, 2020
@jgm
Copy link
Member

jgm commented Feb 7, 2020

I would have thought that running the tests in the normal way would have produced more informative test output. It would really be helpful to know which tests failed. Did you get any more relevant output?

@juhp
Copy link
Contributor Author

juhp commented Feb 8, 2020

Not that I can see by default, unfortunately, but there should be some way to make cmake to give more output.

Anyway this is a just a heads-up FYI. :)

@jgm
Copy link
Member

jgm commented Feb 9, 2020

Try

python3 test/spec_tests.py --program build/src/cmark --spec test/spec.txt

@jgm
Copy link
Member

jgm commented Feb 9, 2020

Oh, never mind, I see it's the round trip tests and not the spec tests that aer at issue.

@jgm
Copy link
Member

jgm commented Feb 9, 2020

For round-trip tests,

python3 test/roundtrip_tests.py --program build/src/cmark --spec test/spec.txt

For normalization,

python3 -m doctest test/normalize.py

QuietMisdreavus pushed a commit to swiftlang/swift-cmark that referenced this issue Jul 26, 2023
warning: assignment discards ‘const’ qualifier from pointer target type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants