Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang-tidy] Narrowing data types is implementation defined #437

Open
alvarogarcia7 opened this issue Jan 30, 2022 · 0 comments · May be fixed by #438
Open

[Clang-tidy] Narrowing data types is implementation defined #437

alvarogarcia7 opened this issue Jan 30, 2022 · 0 comments · May be fixed by #438

Comments

@alvarogarcia7
Copy link

Clang-Tidy: Narrowing conversion from 'unsigned char' to signed type 'char' is implementation-defined

const unsigned char *eol;
S_is_line_end_char(*eol)

where S_is_line_end_char is defined as:

static CMARK_INLINE bool S_is_line_end_char(char c) {
  return (c == '\n' || c == '\r');
}

I'm sending a PR to fix it as well.

@alvarogarcia7 alvarogarcia7 changed the title Narrowing data types is implementation defined [Clang-tidy] Narrowing data types is implementation defined Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant