Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_list_marker Does Not Correctly Check for CRLF. #550

Open
n0s4 opened this issue Jun 24, 2024 · 0 comments
Open

parse_list_marker Does Not Correctly Check for CRLF. #550

n0s4 opened this issue Jun 24, 2024 · 0 comments

Comments

@n0s4
Copy link

n0s4 commented Jun 24, 2024

I'm just reading through the code, and I may be wrong but...

      /* blocks.c > parse_list_marker */

      // require non-blank content after list marker:
      while (S_is_space_or_tab(peek_at(input, i))) {
        i++;
      }
      if (peek_at(input, i) == '\n') {
        return 0;
      }

Seeing as the rest of the parser tries to be compatible with CRLF, I would expect S_is_line_end_char to be used instead of just comparing to a newline char. Am I missing why this is not necessary?

Edit: In the following branch for numbered markers, there is the same logic but S_is_line_end_char is used instead, so I'm pretty sure now that this is an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant