Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified versions #3

Open
Restless-ET opened this issue Apr 15, 2015 · 3 comments
Open

Minified versions #3

Restless-ET opened this issue Apr 15, 2015 · 3 comments

Comments

@Restless-ET
Copy link

Hello

If you don't mind me asking... why this component does not have a minified version available?
Many of the other components have minified versions such as bootstrap, jquery, font-awesome, etc.

Is there any impediment for this one?

@martinlindhe
Copy link
Contributor

I am not sure i can give a correct answer, but i guess that these files are basically wrapped up in a package from http://modernizr.com/, and since they dont provide a minified version, none exist here. they also dont seem to provide any "standard" download (its all customizable), so i'm not really sure what has been put in here.

if you want minified versions you could easily plug in this modernizr.js into your gulp/grunt build script that concats & minifies your other js resources, instead of relying on .min.js files provided to you

@Restless-ET
Copy link
Author

Hmm.. I see.. still, I think we could provide here a minified version assuming that all checkboxes available at http://modernizr.com/download/ under CSS3, HTML5 and Misc. sections are toggled on (then even have a button to toggle all of them at once for each section).

And I'm aware than I can minify this myself but I thought that a minified version would be a nice addition here specially since that's what already happens with other components fetched using composer and people might already be used to that behaviour.

Also I think that most people ends up checking everything on link above before downloading...

Anyway, this is just a suggestion. :-)

@RobLoach
Copy link
Member

RobLoach commented May 5, 2015

@Restless-ET Feel free to open up a PR and someone can merge it in 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants