Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache public key #83

Open
2 tasks done
dholth opened this issue Aug 28, 2023 · 2 comments
Open
2 tasks done

Cache public key #83

dholth opened this issue Aug 28, 2023 · 2 comments
Labels
stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability

Comments

@dholth
Copy link
Contributor

dholth commented Aug 28, 2023

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

Don't create new PublicKey() for each signature verification, when many are being verified against the same key. May save ~750ms.

Why is this needed?

Discovered from benchmark https://github.com/conda/conda-content-trust/actions/runs/6163081698/job/16725868947#step:8:133

What should happen?

conda-content-trust (or the calling code in conda) should create one PublicKey() per unique signing key.

Additional Context

No response

@dholth dholth added the type::feature request for a new feature or capability label Aug 28, 2023
@mohanavamsi20
Copy link

use one key for every unique signing key, it makes it faster and more efficient than creating new for each signature

Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants