Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom updater for bumpFiles/packageFiles not loaded when provided as JS-object #933

Open
StefanHuettenmoserECMT opened this issue Jan 11, 2023 · 1 comment
Labels

Comments

@StefanHuettenmoserECMT
Copy link

Describe the bug
The custom updater is empty when passing it as an JS-object (with readVersion/writeVersion functions). It works when adding it via filepath.

Current behavior
Current output is as bellow. Note the updater is empty. A tracker is supplied with filename (as string) and updater (as object with readVersion/writeVersion-methods).

Unable to obtain updater for: {"filename":".env","updater":{}}

  • Error: Unsupported file (.env) provided for bumping.
    Please specify the updater type or use a custom updater.
  • Skipping...

Expected behavior
Updater should be loaded and not be empty

Environment

  • standard-version version(s): master
  • Node/npm version: [e.g. Node 16/npm 8]
  • OS: [Windows 10]

Possible Solution
When checking if the updater is valid for the first time, the argument should be updater.updater (as in line 80)

Thank you very much for your dedication to this valuable project!

@TimothyJones
Copy link
Contributor

This project is deprecated - but I forked it as commit-and-tag-version here.

I believe this issue was fixed in 10.0.1 of commit-and-tag-version - give it a try and see if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants