Q. This removal of kwargs may break some proxies which use keyword arguments.

• At Rails 7.1 and 7.2, the interface of ActiveRecord::ConnectionAdapters::DatabaseStatements#execute has a keyword argument: https://github.com/rails/rails/blob/f2b4bfb626c52d9cbebd576f615f32ac650fe021/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb#L130
• Also some other adapters have keyword arguments on the interface of patched methods. For example, raw_execute of activerecord-sqlserver-adapter has: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/7dcff7381cc4c2f5f964fbfe95f067327c702be3/lib/active_record/connection_adapters/sqlserver/database_statements.rb#L45

Have you assumed any proxies, which inherits Arprxy::Base, should not accept keyword arguments?

@nekketsuuu Good question.
Indeed, in the current Arproxy, Arproxy::Base#execute actually replaced the call to ConnectionAdapter’s #execute, so kwargs was necessary as an argument.
However, in Arproxy v1, a new class named Arproxy::ConnectionAdapterPatch takes on this role. Arproxy::Base#execute is called with two arguments of (sql, name) from the patch, so kwargs is no longer needed in this context.

https://github.com/cookpad/arproxy/pull/32/files#diff-b0f45f0d5c3f0e5178dce37a7f81a3b41699ebec5c4d0a2a3cff7d5a53b7dbcaR72

I agree that this won't break ConnectionAdapter's execute, but I mean that this may break the behavior of execute of the existing proxies (classes that inherit Arproxy::Base). If these proxies use the given keyword arguments, all of them will be changed to nil in v1. I heard that you'd like to maintain backward compatibility for proxies (#30 ), so I wonder if this is your intention.

IMHO: MySQL 9.0 has been released on 2024-07-01. How about using the latest version of MySQL?

(Please note that the mysql_native_password plugin has been removed at MySQL 9.0. We would be able to choose not to set the password, though.)

nit: How about adding the versions of databases which we run the integration tests?